Hi I made post a few weeks ago on the css help & troubleshooting board on a grunge design mock up. I've been working on converting it to css/html and would just like some feedback on what I have done so far.
firstly congratulations! You did somethin new and you got it up there - thats always a big leap!
Firstly the HTML.
its clean, although there are a few extra divs you don't really need. Examples...
<div id="header"> <h1>the header</h1> </div>
you could just do
<h1 id="header">the header</h1>
the reason being that DIVs H1 to H6 and ULs (amongst other things) are called block elements. So the styling you can do on a div, you can do on a UL for example... so you don't really need to wrap your UL in a DIV...
I've only really glanced at your CSS - but I cant see any major issues (its good to see you using positioning)
Design wise: It maybe grunge, but it looks far too stuck together. the header dosnt match with anything, the menu then dosnt match with the rest and so on... on their own the elements are ok, but you need to keep one theme of grungyness really... it looks a little thrown together.
I made post a few weeks ago on the css help & troubleshooting board on a grunge design mock up. I've been working on converting it to css/html and would just like some feedback on what I have done so far.
https://webspace.utexas.edu/mterr/latin ... index.html
Thanks
Michael
firstly congratulations! You did somethin new and you got it up there - thats always a big leap!
Firstly the HTML.
its clean, although there are a few extra divs you don't really need. Examples...
<div id="header">
<h1>the header</h1>
</div>
you could just do
<h1 id="header">the header</h1>
the reason being that DIVs H1 to H6 and ULs (amongst other things) are called block elements. So the styling you can do on a div, you can do on a UL for example... so you don't really need to wrap your UL in a DIV...
I've only really glanced at your CSS - but I cant see any major issues (its good to see you using positioning)
Design wise: It maybe grunge, but it looks far too stuck together. the header dosnt match with anything, the menu then dosnt match with the rest and so on... on their own the elements are ok, but you need to keep one theme of grungyness really... it looks a little thrown together.
I hope that helped :) and well done again!
it takes away from your other efforts.
Al